rewrite/update of convertkit api libary #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scriber listing by tag
…lazy loading to pull data from first page of paginated results. Convienience method to instatiate a client from a config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had need to access more of the ConvertKit API and started with your python-convertkit as a starting point but ended up doing a pretty major overhaul (certainly not backwards compatible) which has lots of nice features and (biased opinion) better abstractions. Wasn't sure if you had interest in a integrating my changes as a version 2.0, or whether I should spin the project off as it's own thing.
I don't actually expect you'll accept the pull, as documentation and test are still needed. But figured I'd use the pull feature as a way to discuss how the API has changed.